Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperlink miss colon when click in source tag #607

Closed
xiazeyu opened this issue Apr 16, 2022 · 3 comments · Fixed by #608
Closed

hyperlink miss colon when click in source tag #607

xiazeyu opened this issue Apr 16, 2022 · 3 comments · Fixed by #608

Comments

@xiazeyu
Copy link
Contributor

xiazeyu commented Apr 16, 2022 •
edited
Loading

LRR Version and OS
Nightly@d6a7d8a

Bug Details
Given that the page contains three tags:

source:google.com, source:https://google.com, source:http://google.com

The hyper link for these three will be:
google.com, https//google.com and http//google.com

The latter two is unreachable. And in Chrome DevTools, the source is
href="http://https://google.com" and href="http://http://google.com"
@xiazeyu
Copy link
Contributor Author

xiazeyu commented Apr 16, 2022

Also, is there any rules about if these should have https prefix for the plugin system, or it just doesn't matter?

Maybe remove https:// in nHentai.pm should also be considered?
https://github.com/Difegue/LANraragi/blob/dev/lib/LANraragi/Plugin/Metadata/nHentai.pm#L213

@xiazeyu
Copy link
Contributor Author

xiazeyu commented Apr 16, 2022

Also, how about adding source tag import support?
https://github.com/Difegue/LANraragi/blob/dev/lib/LANraragi/Plugin/Metadata/EHentai.pm#L72-L76
to
https://github.com/Difegue/LANraragi/blob/dev/lib/LANraragi/Plugin/Metadata/nHentai.pm#L50

@Difegue
Copy link
Owner

Difegue commented Apr 16, 2022

The scheme shouldn't be present in source tags as you've seen, so the nH plugin should be fixed.

Past that, it'd probably be possible to fix the frontend so that it handles the hyperlinks correctly even if the tags are malformed.

@xiazeyu xiazeyu mentioned this issue Apr 17, 2022
Merged
Difegue pushed a commit that referenced this issue Apr 19, 2022
@xiazeyu
(#607) Handle schemes in source: tags properly
699b81f 
* remove URL scheme in nH plugin

* support for getting galleryID from source tag

* trim output URL

* handles hyperlinks when tags are malformed

* improved RegExp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #607
2 participants
@Difegue @xiazeyu