Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose setting/environment variable for maximum response size #678

Closed
Sircrab opened this issue Aug 9, 2022 · 1 comment
Closed

Expose setting/environment variable for maximum response size #678

Sircrab opened this issue Aug 9, 2022 · 1 comment

Comments

@Sircrab
Copy link

Sircrab commented Aug 9, 2022

When trying to download URLs through some of the plugins, certain galleries exceed the maximum default size for responses set by Mojolicious which causes the job to fail. While this default size is useful for most cases, it'd be great to have this exposed as an environment variable (or setting). The download_url method in the Upload model seems like a good place to check and update this setting to the user agent that gets the gallery.

@Difegue
Copy link
Owner

Difegue commented Aug 19, 2022

huh, I didn't think anyone would hit the 2GB response size limit, but I guess that can happen.
I'm not sure it's worth making this a setting, for downloads we can probably just bump it up to an obscene maximum size like 2TB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants