Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Alpine 3.18 and see if it fixes the problems on Windows #805

Closed
Difegue opened this issue May 9, 2023 · 2 comments
Closed

Move to Alpine 3.18 and see if it fixes the problems on Windows #805

Difegue opened this issue May 9, 2023 · 2 comments

Comments

@Difegue
Copy link
Owner

Difegue commented May 9, 2023

Alpine 3.18 came out literally today and bundles some musl patches to fix DNS over TCP support.

My previous digging pointed those DNS issues as the root cause of #626 on Windows post-Alpine 3.12, so it'd be great if 3.18 fixed everything and allowed me to rip out the windows bandaids.

This'd also give win users proper AVIF/JPEGXL support, which they currently don't have. (see #792)

Difegue added a commit that referenced this issue May 14, 2023
@Difegue
Copy link
Owner Author

Difegue commented May 15, 2023

Downloading seems to work on 3.18-based Windows version - I need to fix some build pipeline stuff to:

  • Make sure we install the previous version of the INotify package (sadly this still ain't fixed with WSL..)
  • Remove the dependency on npm for get-version - it used to not be removed on 3.12 builds but that was an error to begin with

Difegue added a commit that referenced this issue May 17, 2023
@Difegue
Copy link
Owner Author

Difegue commented May 17, 2023

Fixed both of those, things look fine now!

@Difegue Difegue closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant