Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width characters breaks the search function #849

Closed
soarpasser opened this issue Sep 26, 2023 · 3 comments
Closed

Full width characters breaks the search function #849

soarpasser opened this issue Sep 26, 2023 · 3 comments

Comments

@soarpasser
Copy link

soarpasser commented Sep 26, 2023

This is a problem present on current (0.8.90) version of the app, reproed on a Windows 10 msi install.

If you try to enter any full-width characters (CJK, special characters etc.) in the search bar, the search function will not return anything at all until you repeat the query without the full-width characters.

See the video in which I place a demo archive with full-width characters in the filename into the database. The archive is registered on the filemap as you can see in the first second of the video, yet searching the exact filename returns nothing until I delete all the full width characters.

As one can imagine, this creates serious issues for anyone who has their entire database with filenames containing only such characters (e.g. full Japanese).

This issue might be related to #838.

demo.mp4
@Difegue
Copy link
Owner

Difegue commented Sep 27, 2023

works on my machine ™️ Maybe this is windows-specific?

image

@soarpasser
Copy link
Author

works on my machine ™️ Maybe this is windows-specific?

image

Try to add a brand new archive (with full width characters) to the database and do a "first time search" for it, you should be able to reproduce the issue. This is a bit finnicky at times, as through further testing I've realized that this only happens for newly added archives.

@Difegue
Copy link
Owner

Difegue commented Dec 16, 2023

New files were storing a double-encoded version of their filename in the search indexes - which doesn't really cause any trouble with ascii characters but goes south with any other encoding.

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants