Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] file name/path and size in archive metadata #906

Closed
Guerra24 opened this issue Nov 7, 2023 · 3 comments
Closed

[api] file name/path and size in archive metadata #906

Guerra24 opened this issue Nov 7, 2023 · 3 comments

Comments

@Guerra24
Copy link
Contributor

Guerra24 commented Nov 7, 2023

Title. I have been requested this information for the deduper three times, see:

Guerra24/LRReader#21 (comment)
Guerra24/LRReader#33
Guerra24/LRReader#41

So I'm opening this for consideration 馃憖

@Difegue
Copy link
Owner

Difegue commented Nov 7, 2023

All three of those are available and I don't mind adding file name and size -- I don't think path is a good idea as the archive objects are present in public API endpoints and you don't really want to expose server filesystem information there.

@Guerra24
Copy link
Contributor Author

Guerra24 commented Nov 7, 2023

Could file path be restricted behind a toggle in the server to enable/disable it? Or that would be too much of a hustle just for this? This for users who only use it in a private network and don't mind it being "public".

So when disabled it will show only the file name and when using an API key/passwordless with it enabled it will show the entire path.

@Difegue
Copy link
Owner

Difegue commented Dec 16, 2023

Looking at the dedupe tickets in detail I think the filename should be enough information for now. Not sure it'd be worth it to expose the path, sorry!

7256656 should have you sorted for the other two.

@Difegue Difegue closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants