Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing timstamp,category,uploader tags to the eze plugin #606

Merged
merged 8 commits into from
Apr 15, 2022
Merged

Add support for parsing timstamp,category,uploader tags to the eze plugin #606

merged 8 commits into from
Apr 15, 2022

Conversation

xiazeyu
Copy link
Contributor

@xiazeyu xiazeyu commented Apr 14, 2022

fixed #584

BREAK CHANGES: the parameters for tags_from_eze_json has changed to ($save_title, $origin_title, $additional_tags)

  • Add support for date_uploaded and category tags from eze plugin

  • get category from gallery_info, fallback to gallery_info_full

  • change date_uploaded to timestamp add uploader tag for eze
    this make the eze tag more E-Hentai plugin style

  • add EH-plugin like options for eze
    test cases are modified for cross-condition tests

  • better description

  • update basic tags of eze for untagged-archives

  • Update miscellaneous-other-api.md

  • update version number

…ugin

BREAK CHANGES: the parameters for tags_from_eze_json has changed to ($save_title, $origin_title, $additional_tags)

* Add support for date_uploaded and category tags from eze plugin

* get category from gallery_info, fallback to gallery_info_full

* change date_uploaded to timestamp add uploader tag for eze
this make the eze tag more E-Hentai plugin style

* add EH-plugin like options for eze
test cases are modified for cross-condition tests

* better description

* update basic tags of eze for untagged-archives

* Update miscellaneous-other-api.md

* update version number
@xiazeyu xiazeyu mentioned this pull request Apr 14, 2022
@xiazeyu
Copy link
Contributor Author

xiazeyu commented Apr 14, 2022

The test failed... It runs perfectly on my dev environment.
It seems that the docker env lacks CPAN package like:
DateTime or Time::Local

How about adding it? Or just give up converting time from gallery_info.

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remarks but this is overall good -- There's no real breaking changes since tags_from_eze_json is an internal function only called by the eze plugin itself. 👍

lib/LANraragi/Model/Archive.pm Outdated Show resolved Hide resolved
lib/LANraragi/Plugin/Metadata/EHentai.pm Show resolved Hide resolved
lib/LANraragi/Plugin/Metadata/Eze.pm Outdated Show resolved Hide resolved
lib/LANraragi/Plugin/Metadata/Eze.pm Show resolved Hide resolved
lib/LANraragi/Plugin/Metadata/Eze.pm Outdated Show resolved Hide resolved
lib/LANraragi/Plugin/Metadata/Eze.pm Outdated Show resolved Hide resolved
tests/LANraragi/Plugin/Metadata/Eze.t Outdated Show resolved Hide resolved
@xiazeyu xiazeyu marked this pull request as draft April 15, 2022 02:25
@xiazeyu xiazeyu requested a review from Difegue April 15, 2022 02:30
@xiazeyu

This comment was marked as resolved.

@xiazeyu xiazeyu marked this pull request as ready for review April 15, 2022 03:12
@Difegue
Copy link
Owner

Difegue commented Apr 15, 2022

That one's good to go as well 👏 Thanks!

@Difegue Difegue merged commit 8498e96 into Difegue:dev Apr 15, 2022
@xiazeyu xiazeyu deleted the fix-584 branch April 15, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for parsing timestamp tags to the eze plugin
2 participants