Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koromo multiple artists #764

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Conversation

siliconfeces
Copy link
Contributor

If the koromo plugin is run on an info.json where the artist field is actually an array you'd get a garbage artist tag (artist:ARRAY-blabla). I'm not sure if it's because of an update to koromo, or if it's because it's a format mixup since info.json is apparently a very popular filename.

This fixes this by allowing the artist field to be an array. Another way would be to return an error instead, but eh whatever.

@Difegue
Copy link
Owner

Difegue commented Feb 25, 2023

Looks good, merging this! The koromo plugin has historically been used with a ton of other info.jsons since it has one of the most "normalized" formats. It makes sense to try and make it as functional as possible.
I feel like I should rename it at some point to "catchall info.json plugin that might work for you" or something similar...

@Difegue Difegue merged commit af6a9f4 into Difegue:dev Feb 25, 2023
@Difegue
Copy link
Owner

Difegue commented Feb 25, 2023

Holopin made their bot workflow available to individual users so I don't have to issue holobytes and meme badges by making direct API calls anymore, let's try it!

@holopin-bot @siliconfeces holobyte

@holopin-bot
Copy link

holopin-bot bot commented Feb 25, 2023

Congratulations @siliconfeces, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clekkncig058208l67cnngo05

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@siliconfeces siliconfeces deleted the koromo_multiple_artists branch March 3, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants