Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category message #780

Merged
merged 5 commits into from
Mar 18, 2023
Merged

Conversation

siliconfeces
Copy link
Contributor

This PR makes the toast after adding an archive to a category more helpful.
Before:
image
After:
image

More interestingly, it also adds support for backend code (aka perl) to return the success message that appears in toasts.

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance -- Could you edit the example API response in the Docs as well? Thanks!

@siliconfeces
Copy link
Contributor Author

Looks good at a glance -- Could you edit the example API response in the Docs as well? Thanks!

Done, but not sure how to check what the rendered documentation looks like so I might have fucked something up.

@Difegue
Copy link
Owner

Difegue commented Mar 18, 2023

Well, there's no way for me either to know how the doc will look like 'til it lands in dev or master since that's on GitBook's hands, but I'm fairly sure it'll look fine like this.

Mergin' this 👍

@Difegue Difegue merged commit 9720e12 into Difegue:dev Mar 18, 2023
@holopin-bot
Copy link

holopin-bot bot commented Mar 18, 2023

Congratulations @siliconfeces, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clfel9rmc29830fmme0lep9hd

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@siliconfeces siliconfeces deleted the add_category_message branch March 19, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants