Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid await at top level #822

Merged
merged 1 commit into from
Jul 4, 2023
Merged

avoid await at top level #822

merged 1 commit into from
Jul 4, 2023

Conversation

URenko
Copy link
Contributor

@URenko URenko commented Jul 3, 2023

await at top level seems not be allowed in some old browser (Andoird webview in my case).
By using then instead, we can enhance compatibility without any loss.

@Difegue
Copy link
Owner

Difegue commented Jul 3, 2023

The android webview doesn't support await, but front-end ES6 module loading works? ¯\_(ツ)_/¯

Looks good to me if it helps you tho, I'll run some quick testing then merge this.

@URenko
Copy link
Contributor Author

URenko commented Jul 3, 2023

It is not await itself now work, but "await at top level".
It may relate to second item in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await#browser_compatibility

URenko added a commit to ComicLib/comiclib that referenced this pull request Jul 4, 2023
@Difegue Difegue merged commit 9adabdc into Difegue:dev Jul 4, 2023
1 check passed
@holopin-bot
Copy link

holopin-bot bot commented Jul 4, 2023

Congratulations @URenko, you just earned a holobyte! Here it is: https://holopin.io/holobyte/cljomh9ny99130fi97uhvmwv5

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants