Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix img lazy loading #823

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix img lazy loading #823

merged 1 commit into from
Jul 4, 2023

Conversation

URenko
Copy link
Contributor

@URenko URenko commented Jul 4, 2023

Lazy loading will not take effort if the size is unknow, the img will be assumed as 0×0 pixels thus all img will be loaded.

By the way, this patch shows significant difference in loading at Firefox while Chrome still tries loading all img.
It seems that Chrome has more aggressive loading strategy.
I don't if there is a better solution.

@Difegue Difegue merged commit 333a1c3 into Difegue:dev Jul 4, 2023
1 check passed
@holopin-bot
Copy link

holopin-bot bot commented Jul 4, 2023

Congratulations @URenko, you just earned a holobyte! Here it is: https://holopin.io/holobyte/cljomcmpv157070fmnkzi4181b

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

URenko added a commit to ComicLib/comiclib that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants