Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add magazines to koromo #824

Merged
merged 2 commits into from
Jul 5, 2023
Merged

add magazines to koromo #824

merged 2 commits into from
Jul 5, 2023

Conversation

polak14
Copy link
Contributor

@polak14 polak14 commented Jul 4, 2023

the koromo metadata files have a magazine field (e.g COMIC LO..), but the LRR plugin did not add it before.
Already included in the test samples, so no need to update that.
oh.. the expected tags do need to be updated in the tests lol

@Difegue
Copy link
Owner

Difegue commented Jul 5, 2023

Looks simple enough, thank you.
I sometimes feel that I could drop series from the plugin considering it's basically always Original Work these days with the current state of...the "source" of koromo files, but welp might as well leave it in now

@Difegue Difegue merged commit aaffd4b into Difegue:dev Jul 5, 2023
1 check passed
@holopin-bot
Copy link

holopin-bot bot commented Jul 5, 2023

Congratulations @polak14, you just earned a holobyte! Here it is: https://holopin.io/holobyte/cljp0i7v911840gkxbh16pfk9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants