Reuse generate_archive_list to make code more DRY #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. In hindsight I'm not quite sure why the categories page still loads the IDs server-side while Batch does an API call, but I'm constantly flip-flopping on which approach is best so might as well keep it like that for now.. I'll need to make yet another "list all archives and checkbox select some" page for tankoubons soon so maybe I'll make up my mind then |
|
(At least now they both end up using the list code with MULTI so that's good speedwise as mentioned.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Modify Categories" page was rolling some custom code for listing all archives. This PR changes that to reuse the same function as in "Batch Operations", which has the nice side effect of being faster as well.