Set missing ghostscript device value #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - I'd encountered this in recent WSL testing but didn't have time to figure out the issue. I suspect a recent change in ghostscript required this. |
|
wow is this thing actually broken for real now @holopin-bot @TomaSajt cmon guess it's just bytes that are broken smh |
|
Congratulations @TomaSajt, you just earned a badge! Here it is: https://holopin.io/claim/clomzt0y828430fjwbb8sdw0o This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing out pdf conversion on WSL (running NixOS), and ghostscript was complaining that the xserver wasn't running. I found that one line in the pdf info querying code was missing an explicitly specified device, so I'm guessing the xserver was the fallback, which WSL didn't have.
Also tested it on Linux, when I viewed the pdf on the website, the server's monitor started opening many pdf-viewer windows just for a split second, which, because I am using
i3, was continuously messing up the window layout.This simple change should fix both of these issues.
I didn't notice any quality regressions (the quality was not that great before and after the fix, but maybe that's just NixOS)