Use password directly when connecting to Redis #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, I didn't know you could do conditional kvps in Perl either! god bless larry wall for his gift of wacky syntaxes. Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I didn't find every issue with using Redis with a password in a previous PR.
I found that it would sometimes throw
NOAUTHerrors, but only when finishing a Minion job(??) The main thing is that file upload and downloaders were not working at all because of this.After a little more time than I dare to admit, I found a solution: don't use
auth, just use thepasswordkey in the constructor.I don't know a lot of Perl, so after a bit of searching, I found a way to do conditional key-value pairs. If there's a better way, please do tell me.