Update coincontrol.h

[mctrivia]

Fix netflix bug

[ghost]

After small change in the code. ( std:: ) i can build it. The fix is working! Ty @mctrivia
const int DEFAULT_MAX_DEPTH = std::numeric_limits<int>::max();

Screenshot with DEFAULT_MAX_DEPTH = 100;

[ghost]

Tested ACK

[gto90]

cACK

Thank you @mctrivia

[ycagel]

cACK. Thanks @mctrivia!

[JaredTate]

Thank you @mctrivia for finding this and your PR. Wouldn't it be best to add 3 more 9's to the variable to match the same proportions as found in BTC, respecting the 1:1000 DGB to BTC ratio?... well actually our block times are 40x faster... so maybe no need for 1000x more. Or was there another reason you set it to "infinity"?

const int DEFAULT_MAX_DEPTH = 9999999999;

const int DEFAULT_MAX_DEPTH = std::numeric_limits<int>::max();
This variable is set to the maximum possible value for an integer type, as defined by std::numeric_limits::max(). For a typical 32-bit integer, this value would be 2,147,483,647. It's a constant integer variable with a size of 4 bytes. Smaller in size than 9,999,999,999 would allow.

However, in this context, you've mentioned setting it to infinity, but std::numeric_limits::max() doesn't represent infinity; it represents the maximum finite value that can be stored in an int.

To represent infinity in C++, you would typically use a floating-point type and set it to std::numeric_limits<float>::infinity() or std::numeric_limits<double>::infinity()

So setting it to const int DEFAULT_MAX_DEPTH = 9999999999; would allow for coin control to go back 10 billion blocks vs 2.1 billion. Which we are a long way from both. But might as well only bump this once. Cheers

[mctrivia]

@JaredTate technically you are correct it is not infinity. But it is as close to infinity as possible with the restriction that the input is a 32bit integer. Keeping as a limit makes obvious that if the variable gets switched to 64bit that this should change also.

Admittedly using 15 sec timing your suggestion of adding 3x 9s will work for another 4000 years, but if the timing changes or the coin gets really old it will reissue this bug in the future and it may get missed.

*edit actually there isn't room in a 32 bit integer to add 3x 9s so that isn't even possible.

[JaredTate]

Fair point, we will all be dead and AI will have taken over humanity with quantum computers and will have gone interstellar by the time this matters.

ACK. Compiles and runs as expected, though I do not have an old wallet to test the main issue this fixes but I am sure we will get the chance with this bull run as people come out of the woodwork.

[Sbosvk]

For what it's worth, this has been tested by going in the opposite direction and setting a ridiculously low number. You can see the conversation on this Discord thread: https://discord.com/channels/878200503815782400/1212897730129825883