Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value of option 'headSubject' should be rejected when it has the same value as an existing tag. #7

Closed
DigiLive opened this issue Oct 28, 2020 · 0 comments · Fixed by #10
Closed

Value of option 'headSubject' should be rejected when it has the same value as an existing tag. #7

DigiLive opened this issue Oct 28, 2020 · 0 comments · Fixed by #10
Assignees
@DigiLive
Labels
enhancement New feature or request
Milestone
Process Bug Repor...

Comments

@DigiLive
Copy link
Owner

DigiLive commented Oct 28, 2020 •
edited 

$changelog = new MarkDown();
$changelog->setOptions('headSubject', 'v0.4.0');

Expected Result:
Decline value v0.4.0 because it's the value of an existing tag.

Note: headSubject should be call headTagName because it defines a tag name and not a commit subject.

Actual Result:

# Changelog

## v0.4.0 (Undetermined)

* No changes.

## v0.4.0 (2020-10-28)

* Add separate renderers for GitChangelog (2df97ee)
@DigiLive DigiLive added the enhancement New feature or request label Oct 28, 2020
@DigiLive DigiLive reopened this Oct 29, 2020
@DigiLive DigiLive mentioned this issue Oct 31, 2020
Closed
@DigiLive DigiLive self-assigned this Oct 31, 2020
DigiLive pushed a commit that referenced this issue Nov 2, 2020
Fix #7, Fix #8
d4e352e 
- Renamed option `headSubject` to `headTagName` because the option
  involves a tag name instead of subject.

- Renamed option `nextTagDate` to `headTagDate`.

- Option ~~headSubject~~ headTagName can't be set to an existing tag
  name anymore. Having duplicate tag names is ambiguous.

- Reference to HEAD revision in Gitchangelog::gitTags changed from
  'HEAD' to ''. Any non empty value could result in duplicate tag names.
@DigiLive DigiLive linked a pull request Nov 2, 2020 that will close this issue
Milestone 1 #10
Merged
DigiLive pushed a commit that referenced this issue Nov 3, 2020
Add formatting of issues ids & hashes to hyperlink
10816fb 
Closes #9
- The html and markdown renderer, convert issues ids (like #7) into a
  hyperlink which is set as class property.
- The html and markdown renderer, convert hashes (like 2587485) into a
  hyperlink which is set as class property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DigiLive DigiLive

Labels
enhancement New feature or request
Projects
None yet
Milestone
Process Bug Reports and Feature Reque...
Development

Successfully merging a pull request may close this issue.

Milestone 1 DigiLive/gitChangelog
1 participant
@DigiLive