Milestone 1 #10
Merged
Milestone 1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed option `headSubject` to `headTagName` because the option involves a tag name instead of subject. - Renamed option `nextTagDate` to `headTagDate`. - Option ~~headSubject~~ headTagName can't be set to an existing tag name anymore. Having duplicate tag names is ambiguous. - Reference to HEAD revision in Gitchangelog::gitTags changed from 'HEAD' to ''. Any non empty value could result in duplicate tag names.
- Changed shell_exec function calls to exec function call where multiline output is expected. This avoid the overhead of exploding the single output string of shell_exec. - GitChangelog::$setToTag now refers to head revision of repository with value null instead of empty string. - Fixed thrown exceptions at docBlocks.
This was
linked to
issues
Nov 2, 2020
Closed
JBlond
approved these changes
Nov 3, 2020
added 7 commits
November 3, 2020 20:06
- Header 1 tag inside Paragraph tag when there's no commit data. - Issues are always formatted, even with no issueUrl specified. - Hashes are formatted while no commitUrl is specified.
- Removed default value of MarkDown::$issueUrl. - New line prepended to changelog instead of separating the header and message when there's no commit data. - Message has trailing space when there are no subjects. - Hashes are formatted while no commitUrl is specified.
- GitChangeLogTest::testFetchTagsCached expects wrong value. - Changed visibility of GitChangeLogTest::setPrivateProperty(). - Added typehints for parameters of GitChangeLogTest::setPrivateProperty(). - Added typehints for parameters of GitChangeLogTest::getPrivateProperty(). - Removed GitChangeLogTest::testBuildAscendingCommitOrder(). - Removed GitChangeLogTest::testBuildDescendingCommitOrder(). - GitChangeLogTest::testRemoveLabel() tests without default labels. - Add test for removing a label that doesn't exist.
- Unreachable lines taken out from code coverage.
JBlond
approved these changes
Nov 10, 2020
added 7 commits
November 11, 2020 13:43
Instead of defining a path to a file which content is used to append the generated changelog, the generated changelog can now also be appended by any string value.
Remove redundant comments.
Updated to content to reflect changes since commit a6f72c6.
JBlond
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed option
headSubjecttoheadTagNamebecause the optioninvolves a tag name instead of subject.
Renamed option
nextTagDatetoheadTagDate.Option
headSubjectheadTagName can't be set to an existing tagname anymore. Having duplicate tag names is ambiguous.
Reference to HEAD revision in Gitchangelog::gitTags changed from
'HEAD' to ''. Any non empty value could result in duplicate tag names.