Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job card): Added quality inspection for job card #498

Merged
merged 10 commits into from
Sep 2, 2020

Conversation

vishdha
Copy link

@vishdha vishdha commented Aug 21, 2020

@coveralls
Copy link

coveralls commented Aug 21, 2020

Pull Request Test Coverage Report for Build 1940

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1918: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishdha, I'm getting an error if I select Job Card and try to select an item

job-card-issue

Traceback
Traceback (most recent call last):
  File "/home/rohan/psych/apps/frappe/frappe/app.py", line 64, in application
    response = frappe.api.handle()
  File "/home/rohan/psych/apps/frappe/frappe/api.py", line 59, in handle
    return frappe.handler.handle()
  File "/home/rohan/psych/apps/frappe/frappe/handler.py", line 24, in handle
    data = execute_cmd(cmd)
  File "/home/rohan/psych/apps/frappe/frappe/handler.py", line 63, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/rohan/psych/apps/frappe/frappe/__init__.py", line 1054, in call
    return fn(*args, **newargs)
  File "/home/rohan/psych/apps/frappe/frappe/desk/search.py", line 53, in search_link
    search_widget(doctype, txt, query, searchfield=searchfield, page_length=page_length, filters=filters, reference_doctype=reference_doctype, ignore_user_permissions=ignore_user_permissions)
  File "/home/rohan/psych/apps/frappe/frappe/desk/search.py", line 78, in search_widget
    searchfield, start, page_length, filters, as_dict=as_dict)
  File "/home/rohan/psych/apps/frappe/frappe/__init__.py", line 1054, in call
    return fn(*args, **newargs)
  File "/home/rohan/psych/apps/erpnext/erpnext/stock/doctype/quality_inspection/quality_inspection.py", line 98, in item_query
    {'parent': filters.get('parent'), 'txt': "%%%s%%" % txt})
  File "/home/rohan/psych/apps/frappe/frappe/database/database.py", line 156, in sql
    self._cursor.execute(query, values)
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/cursors.py", line 170, in execute
    result = self._query(query)
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/cursors.py", line 328, in _query
    conn.query(q)
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/connections.py", line 517, in query
    self._affected_rows = self._read_query_result(unbuffered=unbuffered)
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/connections.py", line 732, in _read_query_result
    result.read()
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/connections.py", line 1075, in read
    first_packet = self.connection._read_packet()
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/connections.py", line 684, in _read_packet
    packet.check_error()
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/protocol.py", line 220, in check_error
    err.raise_mysql_exception(self._data)
  File "/home/rohan/psych/env/lib/python3.6/site-packages/pymysql/err.py", line 109, in raise_mysql_exception
    raise errorclass(errno, errval)
pymysql.err.InternalError: (1054, "Unknown column 'quality_inspection' in 'where clause'")

@vishdha
Copy link
Author

vishdha commented Aug 28, 2020

@vishdha, I'm getting an error if I select Job Card and try to select an item

job-card-issue

Details

Try Bench migrate

@Alchez
Copy link

Alchez commented Aug 31, 2020

@vishdha, I'm still getting the error after the migrate, check the traceback I've added below the GIF

@vishdha
Copy link
Author

vishdha commented Aug 31, 2020

@vishdha, I'm still getting the error after the migrate, check the traceback I've added below the GIF

@Alchez get filter query try to find parent table which is not present in JOB Card. Item filter query modified according to Job Card.
you may review the PR

@vishdha vishdha requested a review from Alchez August 31, 2020 10:25
@vishdha vishdha requested a review from Alchez August 31, 2020 11:48
@vishdha vishdha requested a review from Alchez September 1, 2020 08:53
Copy link

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this while fetching the item, can you have a look at the query again? I don't see this for the other doctypes.

image

@vishdha
Copy link
Author

vishdha commented Sep 1, 2020

I see this while fetching the item, can you have a look at the query again? I don't see this for the other doctypes.

image

@Alchez this is resolved

@vishdha vishdha requested a review from Alchez September 1, 2020 15:51
@Alchez Alchez merged commit 7c43f7a into Bloomstack:staging Sep 2, 2020
@Alchez Alchez deleted the TASK-2020-1142-2 branch September 2, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants