Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat source #151

Merged
merged 13 commits into from
Jan 9, 2023
Merged

Reformat source #151

merged 13 commits into from
Jan 9, 2023

Conversation

imagingbook
Copy link
Collaborator

I reformatted all LaTeX source files in HgbThesisTutorial as discussed, back again to 80 chars/line (to ease life for split-screen users in Overleaf). This was done semi-automatically since none of the available tools works cleanly, i.e., they all make serious mistakes (particularly around comments and verbatim elements). Some obvious typos and obsolete comments were removed as well.

@hochleitner The document compiles properly but there may be subtle undetected errors. Pls. do a quick check if anything looks out of the normal.

Copy link
Member

@hochleitner hochleitner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look all the files. Looks good to me, I added one commit with two or three things that looked weird after reformatting but nothing serious.

@hochleitner hochleitner merged commit 0b6ae58 into main Jan 9, 2023
@hochleitner hochleitner deleted the reformat-source branch January 9, 2023 08:50
@imagingbook
Copy link
Collaborator Author

@imagingbook
Copy link
Collaborator Author

@hochleitner Should we protect the main branch?

@hochleitner
Copy link
Member

We can, but it would mean that every change would need to be made through a PR.
While I think that this is definitely the responsible way to work it's also more cumbersome for us. There are only a few people with write access to this repo anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants