Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move settings model to top level #368

Closed
alexlittle opened this issue Jul 11, 2016 · 1 comment
Closed

Move settings model to top level #368

alexlittle opened this issue Jul 11, 2016 · 1 comment
Labels
enhancement high priority
Milestone
Mar 2017

Comments

@alexlittle
Copy link
Member

alexlittle commented Jul 11, 2016 •
edited
Loading

Since it will be used by the general Oppia app - not so sure it makes sense to be under the summary package.
@alexlittle alexlittle added this to the Aug 2016 milestone Jul 11, 2016
@alexlittle alexlittle modified the milestone: Aug 2016 Aug 26, 2016
@alexlittle alexlittle modified the milestone: Mar 2017 Jan 5, 2017
@alexlittle
Copy link
Member Author

Will make it much easier for users to update some of the settings if they are in a db model rather than the code.
Main one to initially move will be OPPIA_MAX_UPLOAD_SIZE - but many of the other settings could be moved too

jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jun 28, 2017
@jjoseba
DigitalCampus#368: Moved the SettingProperties model to its own `sett…
33947e7 
…ings` app
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jun 28, 2017
@jjoseba
DigitalCampus#368: Better admin management of settings
d88806e
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jun 28, 2017
@jjoseba
DigitalCampus#368: Added helper methods in model to directly get int …
25a5e5c 
…and string values
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jun 28, 2017
@jjoseba
DigitalCampus#368: Using the MAX_UPLOAD_SIZE from the dynamic setti…
15aacc5 
…ngs table instead of the main settings file
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jun 28, 2017
@jjoseba
DigitalCampus#368: Added explanation of the MAX_UPLOAD_SIZE property …
1339019 
…in the docs
@jjoseba jjoseba mentioned this issue Jun 28, 2017
Merged
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jul 10, 2017
@jjoseba
DigitalCampus#368: Added verbose name to settings model to show in th…
d8338d8 
…e admin page
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jul 10, 2017
@jjoseba
DigitalCampus#368: Corrected import of settings module from summary cron
be6784b
jjoseba added a commit to chaotic-kingdoms/django-oppia that referenced this issue Jul 10, 2017
@jjoseba
DigitalCampus#368: Added migration to populate max upload size settin…
7fa8319 
…gs property with the value from the current settings.py file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement high priority
Projects
None yet
Milestone
Mar 2017
Development

No branches or pull requests
1 participant
@alexlittle