Minimal workaround to fix bug 4831: handles PATH containing '+' characters #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marler8997
changed the title
|
I'm guessing pull requests for this repo aren't looked at very often? |
|
Any status update on this? Is everyone busy? Is no one getting notified about this PR? |
| @@ -1,10 +1,10 @@ | |||
| RELEASE_NUM EQU 0800H | |||
| RELEASE_NUM EQU 0750H | |||
There was a problem hiding this comment.
Eh, this change should be removed.
marler8997
force-pushed
the
FixPlusSignInPath
branch
from
2cafabb
to
3a2aa76
Compare
| @@ -36,10 +36,26 @@ unsigned char *_get_filename(CMDLINE_STRUCT *EAX, NFN_STRUCT* ECX, unsigned char | |||
| else | |||
| { | |||
| *EDI++ = AL; | |||
| if (!(FNTBL[AL] & FNTBL_ILLEGAL)) | |||
| if (!(FNTBL[AL] & FNTBL_ILLEGAL) || AL == ' ') | |||
There was a problem hiding this comment.
What is the purpose of accepting spaces here?
|
I'll just merge it and tweak it a bit. Thanks for doing this! |
WalterBright
added a commit
that referenced
this pull request
Jan 30, 2015
Minimal workaround to fix bug 4831: handles PATH containing '+' characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a potential workaround for the issue of the PATH environment variable containing '+' characters. If I understand the code correctly, I believe this workaround will silently ignore any folders in the path that contain the '+' character. I would anticipate this most likely occurring on anyone who has notepad++ installed and in their PATH directory. I've included a commented printf statement if anyone wants to use it to verify that the change detects the '+' sign correctly.
Bug Here: https://issues.dlang.org/show_bug.cgi?id=4831