Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to lock package dependencies. #632

Closed
hbowden opened this issue Feb 13, 2018 · 1 comment
Closed

Need to lock package dependencies. #632

hbowden opened this issue Feb 13, 2018 · 1 comment
Labels
0.1.0 Dev Experience

Comments

@hbowden
Copy link
Contributor

hbowden commented Feb 13, 2018

We need to lock our dependencies so all devs get the same build and so bugs upstream don't break our builds 1. However npm5 is very broken and at last try fails to install react-atlas correctly. So we either need to aggressively push npm5 bugs reports upstream or use yarn or shrinkwrap.
@stuller stuller added Dev Experience and removed bug labels Mar 9, 2018
hbowden added a commit to hbowden/react-atlas that referenced this issue Jun 11, 2018
@hbowden
Add package lock and stop ignoring them. Fixes DigitalRiver#632
b004877
hbowden added a commit to hbowden/react-atlas that referenced this issue Jun 11, 2018
@hbowden
Add package lock and stop ignoring them. Fixes DigitalRiver#632
195a929
Darper added a commit that referenced this issue Jun 11, 2018
@Darper
Merge pull request #791 from hbowden/lock
4e290b1 
Add package lock and stop ignoring them. Fixes #632
@hbowden
Copy link
Contributor Author

hbowden commented Jun 11, 2018

Fixed by #791

@hbowden hbowden closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.1.0 Dev Experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuller @hbowden