Fix usernames appearing in all lowercase #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason it was getting the usernames from the username_clean column instead of the username column, this means usernames were appearing in all lowercase (except for the first character.) This fixes it so that usernames appear in the correct case. This is however a problem in already installed installations, because it means that if this is changed then old usernames that were previously made lowercase will not match up with new ones. So this sets the default to make all usernames lowercase so as not to break existing installations.
|
I think when I first built this, I was trying to make the names in phpBB match those in the wiki. So I forced everything to be lowercase with the first char upper. username_clean is the case folded version of a username. I like that you made this change configurable. |
|
Ah I see, I just assumed it was overlooked somehow. Do you think it's missing anything for it to merged? |
|
I need to figure out the impact to non-latin base users. There was a big issue years ago. So just give me time to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it was getting the usernames from the username_clean
column instead of the username column, this means usernames were
appearing in all lowercase (except for the first character.) This fixes
it so that usernames appear in the correct case.
This is however a problem in already installed installations, because it
means that if this is changed then old usernames that were previously made
lowercase will not match up with new ones. So this sets the default to
make all usernames lowercase so as not to break existing installations.