Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messages about json parsing errors #71

Closed
TheMostDiligent opened this issue Dec 16, 2021 · 0 comments · Fixed by #82
Closed

Improve messages about json parsing errors #71

TheMostDiligent opened this issue Dec 16, 2021 · 0 comments · Fixed by #82
Assignees

Comments

@TheMostDiligent
Copy link
Contributor

The tool now prints the following error which does not tell which file exactly caused the problem:

terminate called after throwing an instance of 'nlohmann::detail::parse_error'
  what():  [json.exception.parse_error.101] parse error at line 62, column 13: syntax error while parsing value - unexpected ']'; expected '[', '{', or a literal
terminate called recursively
Aborted (core dumped)
ninja: build stopped: subcommand failed.
ninja: build stopped: subcommand failed.

An error message should be clear about which file exactly failed to parse.

MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
MikhailGorobets added a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 18, 2021
@MikhailGorobets MikhailGorobets linked a pull request Dec 20, 2021 that will close this issue
TheMostDiligent pushed a commit to MikhailGorobets/DiligentTools that referenced this issue Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants