Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: changes on identifier #11441

Merged
merged 2 commits into from
Apr 28, 2024
Merged

revert: changes on identifier #11441

merged 2 commits into from
Apr 28, 2024

Conversation

Jack-Works
Copy link
Member

mf-0000

cc @guanbinrui I need to revert your change in #11305, please open a related PR in firefly and I'll go there fix the toolchain problem.

@Jack-Works Jack-Works added this to the 2.25.0 milestone Feb 26, 2024
@guanbinrui
Copy link
Member

guanbinrui commented Feb 26, 2024

It might a be configuration issue. DimensionDev/mask.social doesn't support private properties with # syntax.

@Jack-Works
Copy link
Member Author

It might a be configuration issue. DimensionDev/mask.social doesn't support private properties with # syntax.

yes, please open a PR on that project and I'll go to fix the configuration issue.

@Jack-Works Jack-Works added this pull request to the merge queue Apr 28, 2024
Merged via the queue into develop with commit c198cc3 Apr 28, 2024
14 checks passed
@Jack-Works Jack-Works deleted the revert-ident branch April 28, 2024 08:48
swkatmask added a commit that referenced this pull request Apr 29, 2024
swkatmask added a commit that referenced this pull request Apr 30, 2024
guanbinrui pushed a commit that referenced this pull request Apr 30, 2024
* fix: patch useAsyncFn

* Revert "revert: changes on identifier (#11441)"

This reverts commit c198cc3.
Jack-Works added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants