feat: firefly rp #11305
Merged
feat: firefly rp #11305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
force-pushed
the
firefly-rp
branch
from
141dc25
to
53ddaae
Compare
guanbinrui
force-pushed
the
firefly-rp
branch
2 times, most recently
from
8f0141a
to
a84b23d
Compare
guanbinrui
force-pushed
the
firefly-rp
branch
from
31ffb15
to
758c90f
Compare
Jack-Works
reviewed
Jan 23, 2024
| @@ -137,9 +137,8 @@ export class ECKeyIdentifier extends Identifier { | |||
| ) | |||
| } | |||
| declare [Symbol.toStringTag]: string | |||
| #ec: undefined | |||
There was a problem hiding this comment.
I think this change should not be landed. I can provide help with toolchain on firefly side.
Jack-Works
reviewed
Jan 23, 2024
| @@ -2,8 +2,7 @@ import { SnapshotContext } from '../context.js' | |||
| import { getProposalIdentifier } from './helpers.js' | |||
| import { Snapshot } from './Snapshot.js' | |||
| import { LoadingFailCard } from './LoadingFailCard.js' | |||
| // @ts-expect-error undocumented api | |||
| import { unstable_Cache as Cache, unstable_useCacheRefresh } from 'react' | |||
| import { unstable_useCacheRefresh } from 'react' | |||
There was a problem hiding this comment.
unstable_Cache and unstable_useCacheRefresh should be used together. use only one may cause bug.
Jack-Works
reviewed
Jan 23, 2024
* refactor: migrate ff-PC preset * refactor: preset & dimension
Jack-Works
reviewed
Jan 24, 2024
| @@ -0,0 +1,34 @@ | |||
| import type { Dimension } from './presets.js' | |||
|
|
|||
| export async function getDimensionAsBlob(file: Blob | string): Promise<Dimension | undefined> { | |||
There was a problem hiding this comment.
I don't think this should go here. Maybe you should add it in https://github.com/DimensionDev/kit this library (@masknet/kit). If you need help, please ping me
There was a problem hiding this comment.
please remove this file as it has already landed in the kit package.
Jack-Works
reviewed
Jan 24, 2024
Co-authored-by: Jack Works <jackworks@protonmail.com>
* feat: fw-276 claim redpacket * fixup! feat: fw-276 claim redpacket * fixup! feat: fw-276 claim redpacket
* feat: create redpacket with api * chore: reply review * fix: bugfix * fix: bugfix
* feat: redpacket history * fix: page loading * fix: remove unused * chore: remove debug code * fix: page loading * chore: code review * chore: lint * fix: height * chore: lint * chore: revert lock file * refactor: root url * chore: prettier * chore: code review * chore: review --------- Co-authored-by: guanbinrui <guanbinrui@dimension.im>
* fix: bugfix for claim ui * chore: prettier * chore: reply review
* fix(RedPacket): fw-396 allow to omit password in payload * fixup! fix(RedPacket): fw-396 allow to omit password in payload
* fix: share rp * feat: update rp payload * fix: fw-333 * fix: fw-363 * fix: action button * fix: fw-363 * fix: fw-381 * feat: fw-372 * feat: add post on * fix: post on * fix: history claimed * fix: review * fix: code review * chore: code review * chore: code review
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
* fix: bugfix for wallet status bar * fix: share compose
* fix: should pass current profile id instead of author's * fixup! fix: should pass current profile id instead of author's
* fix: type error * fix: type error * chore: prettier * chore: eslint --------- Co-authored-by: nuanyang233 <nuanyang233@gmail.com>
guanbinrui
force-pushed
the
firefly-rp
branch
from
8216607
to
70c2ad0
Compare
guanbinrui
force-pushed
the
firefly-rp
branch
from
0c66f86
to
f91c7f1
Compare
guanbinrui
force-pushed
the
firefly-rp
branch
from
ff670e3
to
e624710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes MF-0000
Type of change
Previews
Checklist
console.logsIf this PR depends on external APIs:
chrome-extension://[id]moz-extension://[id]