-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefly PC v5.2.0 #11610
Draft
guanbinrui
wants to merge
67
commits into
develop
Choose a base branch
from
firefly
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Firefly PC v5.2.0 #11610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add chain configs * feat: add chain icons
* chore: bump version to 2.26.2 * refactor: config * refactor: default constants is {}
* feat: get params `count` to poap event api * feat: add pageable total
@@ -10,7 +10,7 @@ | |||
|
|||
export function getCommunityLink(links: string[]): TrendingAPI.CommunityUrls { | |||
return links.map((x) => { | |||
if (x.includes('twitter')) return { type: 'twitter', link: x } | |||
if (x.includes('twitter') || x.includes('x.com')) return { type: 'twitter', link: x } |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
' ' can be anywhere in the URL, and arbitrary hosts may come before or after it.
x.com
Error loading related location
Loading There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guanbinrui @swkatmask you must use this
import { isDomainOrSubdomainOf } from '@masknet/shared-base'
if (isDomainOrSubdomainOf(x, 'x.com')) return { type: 'twitter', link: x }
otherwise, v2ex.com also passes this test.
* fix: fw-1575 only list supported chains in token picker * fix: follow up reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
getOwnersByContract
apifeat: adjust
getOwnersByContract
paramscursor
Description
Closes MF-0000
Type of change
Previews
Checklist
console.log
sIf this PR depends on external APIs:
chrome-extension://[id]
moz-extension://[id]