Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow failed #8287

Merged
merged 3 commits into from
Dec 16, 2022
Merged

fix: follow failed #8287

merged 3 commits into from
Dec 16, 2022

Conversation

lelenei
Copy link
Contributor

@lelenei lelenei commented Dec 15, 2022

Description

Closes mf-2999

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@lelenei lelenei added this to the 2.17.0 milestone Dec 15, 2022
wlanroot
wlanroot previously approved these changes Dec 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

@github-actions github-actions bot temporarily deployed to pull request December 15, 2022 09:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 16, 2022 03:17 Inactive
@guanbinrui guanbinrui merged commit 00c07b2 into develop Dec 16, 2022
@guanbinrui guanbinrui deleted the lelenei/mf-2999 branch December 16, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants