fix: mf-2818 match multiple ENS and Space Id #8359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleBill
force-pushed
the
fix/mf-2818-match-multiple-ens-space-id
branch
from
8074e08
to
1c1584d
Compare
guanbinrui
reviewed
Dec 27, 2022
Comment on lines
34
to
35
| .filter(Boolean) | ||
| .flatMap((result) => [...result!]) |
There was a problem hiding this comment.
Suggested change
| .filter(Boolean) | |
| .flatMap((result) => [...result!]) | |
| .flatMap((result) => result ?? []) |
Comment on lines
34
to
35
| .filter(Boolean) | ||
| .flatMap((result) => [...result!]) |
There was a problem hiding this comment.
Suggested change
| .filter(Boolean) | |
| .flatMap((result) => [...result!]) | |
| .flatMap((result) => result ?? []) |
guanbinrui
reviewed
Dec 27, 2022
| return compact(allSettled.map((x) => (x.status === 'fulfilled' ? x.value : undefined)).filter(Boolean)) | ||
| return uniqBy( | ||
| compact(allSettled.map((x) => (x.status === 'fulfilled' ? x.value : undefined))), | ||
| (x) => x.address, |
There was a problem hiding this comment.
Suggested change
| (x) => x.address, | |
| (x) => x.address.toLowerCase(), |
| return compact(allSettled.map((x) => (x.status === 'fulfilled' ? x.value : undefined)).filter(Boolean)) | ||
| return uniqBy( | ||
| compact(allSettled.map((x) => (x.status === 'fulfilled' ? x.value : undefined))), | ||
| (x) => x.address, |
There was a problem hiding this comment.
Suggested change
| (x) => x.address, | |
| (x) => x.address.toLowerCase(), |
UncleBill
force-pushed
the
fix/mf-2818-match-multiple-ens-space-id
branch
from
1c1584d
to
ad32b7f
Compare
guanbinrui
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/MF-2818