This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
1.13.1 Port #58
Open
1.13.1 Port #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more compile errors, but there are definitely some Mixins that don't work (or make sense) with 1.13
Now it compiles too
Bundled the updating script designed to do MCP methods to Notch names too, fields and classes are comparatively easier (and faster)
Game can now load to the world
Don't think anything changed that was being used, but that's what I was using Also updates the profile to extend from 1.13.1
`ItemRenderer` will cause `ModelResourceLocation` to crash unhelpfully if an item is registered with a null resource location This doesn't fix the fact it crashes, just allows for the item to be found
Now there is a proper dimension registry the old hacks can start to be removed Breaks the test mod loading into the world from `MixinMinecraftServer` needing updating too Removes ATing string registering methods when there are resource location versions instead
Mojang now has a `DimensionType` -> `World` map instead of the old `World[]` array so most of the old hacks can go
Most `ClientTickable`s will need it anyway, so might as well make it as convenient as `ServerTickable` is
Technically `func_212321_a` is the proper portal teleport, but it has a whole load of expectations that makes it break too easily So we just jump on the TeleportCommand which is actually designed for what we're using it for
It's less annoying now, but still worth testing to make sure enum extending is fine
It's been replaced in favour of the `Message` system for a while now
|
Guys why is there another fork of this ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplants #50, effectively applies #54. All access transformations have been updated, as have the MCP mappings and the test mod now compiles. Still need to update some overwrite Mixins that definitely don't work correctly anymore, but it loads into the world a basic things work.