Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: items should not reset every rebuild #132

Merged
merged 1 commit into from Feb 4, 2022
Merged

Conversation

jamesblasco
Copy link
Contributor

@jamesblasco jamesblasco commented Jan 12, 2022

Right now every time the widget is rebuilt, a new GlobalKey is created for each item resetting any state that the widget could have inside.

This keeps the same GlobalKeys between rebuilds

@Dimibe
Copy link
Owner

Dimibe commented Feb 4, 2022

Hello @jamesblasco,
thanks for your contribution. I will look into it.

@Dimibe Dimibe self-assigned this Feb 4, 2022
@Dimibe Dimibe added the new feature New feature or request label Feb 4, 2022
@Dimibe Dimibe merged commit fd29f0e into Dimibe:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants