Merge retry logic into a single decorator #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requiring simple Iterable type to pass the exceptable exceptions for the retry decorator wasn't viable since except can only take a type which inherits from BaseException or a tuple of these exception types. - While this could also be done by converting the iterable into a tuple, that just brings additional overhead when the types could simply be passed in as a tuple to start with.
- Retrying connection creation and establishment isn't what we want to do in many cases. - This is the reason tests for the server were failing! - Even if it doesn't mean breakage, it's not worth to retry code that can only run once, it introduces unnecessary delays - The downside to this is that the code looks a lot messier, but at least with some methods, it's absolutely necessary, as for the others, if this isn't desired it can be mentioned in the PR review.
|
The I've done this because we only want to repeat a certain part of those functions and it doesn't make sense to decorate the whole function and re-run everything in it. Not only would that be inefficient, it often wouldn't even be what's desired and may cause issues. |
kevinkjt2000
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
As discussed in the issue, this introduces a retry decorator which will automate the logic of retrying the code for several specified amount of tries until the function was successful or if the function failed in each of the tries, raise the last exception that occurred.