Adding net crate #123
Adding net crate #123
Conversation
kokoISnoTarget
force-pushed
the
net
branch
3 times, most recently
from
4fff0f2
to
4b338f2
Compare
|
Oh wow. This PR makes Blitz feel fast (or at least, it did before the workaround was added). Would love to get this merged soon. The stylesheet bug is pretty bad though. We'll need to get to the bottom of that. It looks like it might only be inline nodes that styles aren't applying to, but I'm not quite sure why that would be as it looks like that's getting rebuilt every frame. |
kokoISnoTarget
force-pushed
the
net
branch
2 times, most recently
from
dcffe98
to
9f2db68
Compare
kokoISnoTarget
force-pushed
the
net
branch
2 times, most recently
from
f106865
to
98bad27
Compare
There was a problem hiding this comment.
Looks like you've found the invalidation bug - nice!
I've put some review comments which I thought I had already sent, but looks like I didn't press the button. Please feel free to push back if you disagree with any of my comments: I think this is somewhere where there is quite a large design space and probably many good options.
One thing I am quite keen on is to minimise dependencies between crates. As such I would like the net crate to be as close to "url in, bytes out" as possible.
| futures: Mutex::new(FuturesUnordered::new()), | ||
| } | ||
| } | ||
| pub fn resolve<P: From<(WindowId, T)> + Send>( |
There was a problem hiding this comment.
If you have fetch accept the WindowId and the callback for the result directly, then I think this resolve function can be removed.
There was a problem hiding this comment.
The problem is that basically all fetching is done before the window (and the WindowId) exist.
There was a problem hiding this comment.
I think this could be solved by giving the Document itself an ID The ID (perhaps just a simple sequential one?) could be generated either by the high-level glue code (or by Document::new()) and then the high-level code could keep track of which windows/documents that ID corresponds to.
This seems like a good idea anyway as in future we'll likely want to support things like replacing the Document associated with a Window (e.g. when clicking on a link), and having sub-Documents within a Document (e.g. for iframes, or using DioxusDocument wrapping an HtmlDocument to implement a browser ui).
…oving sync provider (im sorry)
packages/dioxus-blitz/Cargo.toml
Outdated
| @@ -26,6 +26,9 @@ style = { workspace = true } | |||
| tracing = { workspace = true, optional = true } | |||
| blitz = { path = "../blitz" } | |||
| blitz-dom = { path = "../dom" } | |||
| blitz-net = { path = "../net" } | |||
| blitz-traits = { path = "../traits" } | |||
| html-escape = "0.2.13" | |||
There was a problem hiding this comment.
Is html-escape actually used in this crate?
There was a problem hiding this comment.
Nope, forgot to remove it.
examples/screenshot.rs
Outdated
| Arc::new(callback) as SharedCallback<Resource>, | ||
| )); | ||
|
|
||
| timer.time("Setup document prerequsits"); |
There was a problem hiding this comment.
Typo: "prerequsits" should be "prerequisites"
|
Regarding the |
This adds a
netcrate with sync and async networking Providers as mentioned in #119 and the discord.Please comment any thoughts regarding the implementation.