Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hotreloading issues, clean up the CLI a bit #2055

Merged
merged 14 commits into from Mar 15, 2024
Merged

Fix hotreloading issues, clean up the CLI a bit #2055

merged 14 commits into from Mar 15, 2024

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Mar 11, 2024 •
edited

Fixes some untracked issues:

  • hot reloading currently doesn't update on reloads
  • latent websocket connections aren't dropped
  • hot reload file map technically only allows one template per pathbuf (file)
  • assets weren't being reloaded
  • css is now hot reloaded using query-segment invalidation

@jkelleyrtp jkelleyrtp mentioned this pull request Mar 13, 2024
Closed
3 tasks
@jkelleyrtp jkelleyrtp changed the title Fix hotreloading issues, clean up the CLI a bit, fix nasm requirement Fix hotreloading issues, clean up the CLI a bit Mar 13, 2024
@jkelleyrtp jkelleyrtp marked this pull request as ready for review March 14, 2024 00:18
@marc2332 marc2332 mentioned this pull request Mar 14, 2024
Merged
@jkelleyrtp jkelleyrtp merged commit 01a0917 into main Mar 15, 2024
6 of 9 checks passed
@jkelleyrtp jkelleyrtp deleted the jk/fix-hotreloading-issues branch March 15, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jkelleyrtp