Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot-reloading doesn't drop disconnected websocket connections #2075

Closed
3 tasks
jkelleyrtp opened this issue Mar 13, 2024 · 0 comments · Fixed by #2055
Closed
3 tasks

Hot-reloading doesn't drop disconnected websocket connections #2075

jkelleyrtp opened this issue Mar 13, 2024 · 0 comments · Fixed by #2055
Assignees
@jkelleyrtp
Labels
hot-reload Related to the hot reload crate

Comments

@jkelleyrtp
Copy link
Member

Problem

If you drop a WS connection, the poll loop to send down edits stays alive until next rebuild since it's not running a heartbeat.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

  • Dioxus version: [e.g. v0.17, master]
  • Rust version: [e.g. 1.43.0, nightly]
  • OS info: [e.g. MacOS]
  • App platform: [e.g. web, desktop]

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@jkelleyrtp jkelleyrtp added the hot-reload Related to the hot reload crate label Mar 13, 2024
@jkelleyrtp jkelleyrtp self-assigned this Mar 13, 2024
@jkelleyrtp jkelleyrtp mentioned this issue Mar 13, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkelleyrtp jkelleyrtp

Labels
hot-reload Related to the hot reload crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hotreloading issues, clean up the CLI a bit DioxusLabs/dioxus
1 participant
@jkelleyrtp