Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Zip streaming #1119

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat: Add Zip streaming #1119

merged 6 commits into from
Mar 12, 2024

Conversation

Arno500
Copy link
Contributor

@Arno500 Arno500 commented May 27, 2023

@Arno500 Arno500 requested a review from PHLAK as a code owner May 27, 2023 21:24
@PHLAK PHLAK self-assigned this Jun 2, 2023
@PHLAK PHLAK added the Enhancement New feature or improvement to existing functionality label Jun 2, 2023
@PHLAK
Copy link
Member

PHLAK commented Jun 2, 2023

Thank you! Sorry, for not responding sooner but I was out of town earlier this week. I will review this soon.

Copy link
Member

@PHLAK PHLAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the PR focused on only the changes necessary for implementing Zip streaming. I see a lot of changes that aren't relevant to this PR. I believe this is due to running a composer update which should not have been done. Please revert the changes to composer.lock and then run composer require maennchen/zipstream-php to only install that package without updating pre-existing dependencies.

composer.json Outdated Show resolved Hide resolved
composer.lock Outdated Show resolved Hide resolved
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity and will be closed if no further activity occurs.

@stale stale bot added the WontFix label Dec 15, 2023
@PHLAK PHLAK added Pinned Prevents an issue from being automatically closed and removed WontFix labels Dec 15, 2023
@Arno500
Copy link
Contributor Author

Arno500 commented Dec 17, 2023

Hello @PHLAK !

I updated the review rebased on the master with the CS fixes. I ran the testing suite in my repo and everything seems OK.
There is still an issue with CS, but this issue is also present on master in the latest commit since the bumps and fixes. I'll leave that to you!

@PHLAK
Copy link
Member

PHLAK commented Dec 17, 2023

Thanks @Arno500! I have some time off coming up and was planning on getting to this then.

composer.json Outdated Show resolved Hide resolved
@PHLAK
Copy link
Member

PHLAK commented Dec 30, 2023

I've pushed some dependency updates and fixed CI. Please rebase and push the updates discussed when you have a moment and we can hopefully get this merged.

@Arno500 Arno500 force-pushed the master branch 4 times, most recently from 6c2ba35 to 50396c4 Compare March 9, 2024 01:55
@Arno500
Copy link
Contributor Author

Arno500 commented Mar 9, 2024

Done!

Copy link
Member

@PHLAK PHLAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments but otherwise this is looking good.

app/src/Controllers/ZipController.php Outdated Show resolved Hide resolved
app/src/Controllers/ZipController.php Outdated Show resolved Hide resolved
@PHLAK PHLAK merged commit d568bc1 into DirectoryLister:master Mar 12, 2024
7 checks passed
@PHLAK
Copy link
Member

PHLAK commented Mar 12, 2024

Thank you for all the hard work @Arno500!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to existing functionality Pinned Prevents an issue from being automatically closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants