-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Zip streaming #1119
feat: Add Zip streaming #1119
Conversation
Thank you! Sorry, for not responding sooner but I was out of town earlier this week. I will review this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the PR focused on only the changes necessary for implementing Zip streaming. I see a lot of changes that aren't relevant to this PR. I believe this is due to running a composer update
which should not have been done. Please revert the changes to composer.lock
and then run composer require maennchen/zipstream-php
to only install that package without updating pre-existing dependencies.
This issue has been automatically marked as stale because it has not had recent activity and will be closed if no further activity occurs. |
Hello @PHLAK ! I updated the review rebased on the master with the CS fixes. I ran the testing suite in my repo and everything seems OK. |
Thanks @Arno500! I have some time off coming up and was planning on getting to this then. |
I've pushed some dependency updates and fixed CI. Please rebase and push the updates discussed when you have a moment and we can hopefully get this merged. |
6c2ba35
to
50396c4
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small comments but otherwise this is looking good.
Thank you for all the hard work @Arno500! |
#1118