Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The HSV textboxes are not working #2

Open
jelkevanhoorn opened this issue May 18, 2020 · 2 comments
Open

The HSV textboxes are not working #2

jelkevanhoorn opened this issue May 18, 2020 · 2 comments

Comments

@jelkevanhoorn
Copy link

The HSV textboxes keep displaying 360/100/100. The spinner control next to it works.
Looking into the code there seems to be a discrepancy between the values for S and V, at one place 0-1 is expected at another 0-100.
Dirkster99 added a commit that referenced this issue Jul 15, 2020
@Dirkster99
Fixing Issue #2 by ensuring correct maximum HUE value of 359.
cd988d2
Dirkster99 added a commit that referenced this issue Jul 15, 2020
@Dirkster99
Merge pull request #3 from Dirkster99/Fix_Issue2
204bc9d 
Fixing Issue #2 by ensuring correct maximum HUE value of 359.
@Dirkster99
Copy link
Owner

Hi, thanks for reporting the issue - I think I've resolved it now - can you confirm the resolution with the current master branch please?

@jelkevanhoorn
Copy link
Author

jelkevanhoorn commented Jul 16, 2020 •
edited
Loading

I'm afraid it doesn't work.
The values in the textboxes do sometimes change, but mostly it is 359/100/100 now.
The spinners still change the color as expected :)

colorpicker (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dirkster99 @jelkevanhoorn