Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Search bar needs to search whole term #479

Closed
2 tasks
ericchen59 opened this issue Oct 18, 2020 · 3 comments
Closed
2 tasks

Contact Search bar needs to search whole term #479

ericchen59 opened this issue Oct 18, 2020 · 3 comments
Labels
bug Something isn't working invalid This doesn't seem right
Milestone

Comments

@ericchen59
Copy link

ericchen59 commented Oct 18, 2020

Bug: On the contacts page, when type in a search term, the searching behavior only reacts to the first two letters. See the video here: https://drive.google.com/file/d/1b0KDCBN4aW9C_apLE09scrnjnJyH4Lo5/view?usp=sharing

User Story: As a user, I want to be able to type in the partial or full name of a contact so that the contacts list live filters results that match the search term I am typing in

Acceptance Criteria:

  • search filters instataneously as user types
  • no limit to search term (currently the search only live filters the first two characters)
@ericchen59 ericchen59 added bug Something isn't working invalid This doesn't seem right labels Oct 18, 2020
@ericchen59 ericchen59 added this to the 1 Backlog Candidates milestone Oct 18, 2020
@ericchen59 ericchen59 modified the milestones: 1 Backlog Candidates, 2 Backlog Confirmed, 3 Ready Oct 29, 2020
@raschdiaz-zz
Copy link
Contributor

Hi @ericchen59 we can't see the video, we need to you give us permissions or let the video with public access.

Can you add more details about the 'search live filters as user types' flow?

@ericchen59
Copy link
Author

@raschdiaz video permission and acceptance criteria updated

@ericchen59 ericchen59 modified the milestones: 3 Ready, 4 Sprint 30 Nov 4, 2020
@ericchen59 ericchen59 added the TDM label Nov 4, 2020
@raschdiaz-zz
Copy link
Contributor

Hi @ericchen59 see the following video with the fix:

https://drive.google.com/file/d/1jZvrxIIMJiNKMonMUTAgOlv7TQ1dFQLL/view?usp=sharing

The reason the list does not change, its because the filter does not return results. Now the filter fill show records (or not) according to the current text filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants