Fix InviteCreateEvent.getExpiration impl after #1099

Discord4J · Mar 20, 2023 · ad64fcd · ad64fcd
1 parent 7912be1
commit ad64fcd
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/core/src/main/java/discord4j/core/event/domain/InviteCreateEvent.java b/core/src/main/java/discord4j/core/event/domain/InviteCreateEvent.java
@@ -139,9 +139,9 @@ public int getMaxAge() {
     }
 
     /**
-     * Gets whether or not the invite is temporary (invited users will be kicked on disconnect unless they're assigned a role).
+     * Gets whether this invite only grants temporary membership.
      *
-     * @return Whether or not the invite is temporary.
+     * @return {@code true} if this invite only grants temporary membership
      */
     public boolean isTemporary() {
         return temporary;
@@ -162,10 +162,7 @@ public Instant getCreation() {
      * @return The instant this invite expires, if possible.
      */
     public Optional<Instant> getExpiration() {
-        final boolean temporary = isTemporary();
-        final int maxAge = getMaxAge();
-
-        return temporary ? Optional.of(getCreation().plus(maxAge, ChronoUnit.SECONDS)) : Optional.empty();
+        return maxAge > 0 ? Optional.of(getCreation().plus(maxAge, ChronoUnit.SECONDS)): Optional.empty();
     }
 
     /**