Add support for application command auto complete #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovaFox161
added
enhancement
j0rdanit0
reviewed
Oct 30, 2021
core/src/main/java/discord4j/core/event/domain/interaction/ChatInputAutoCompleteEvent.java
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/java/discord4j/core/object/command/ApplicationCommandOption.java
quanticc
approved these changes
Nov 6, 2021
LociStar
added a commit
to LociStar/Organizer
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for the new
APPLICATION_COMMAND_AUTOCOMPLETEinteraction type.Due to the fact that it only allows 1 response method and cannot be deferred, I had to change the interaction hierarchy once again.
This hierarchy change shouldn't require special migration steps unless developers are listening directly to the
InteractionCreateEventrather than a specialized event for the specific interaction type.The
AutoCompleteInteractionEventis a placeholder event currently as discord does have plans to add more types of auto complete. However, it is currently unknown how they will be structured (sub-typed like application commands or each a different type of interaction completely).Since all interaction classes are marked as experimental, I have targeted 3.2 with this change.
Justification: