Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote and standardize the creation of displayable strings for emoji #1121

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Promote and standardize the creation of displayable strings for emoji #1121

merged 2 commits into from
Mar 29, 2023

Conversation

kashike
Copy link
Contributor

@kashike kashike commented Mar 2, 2023

Description/Justification: This pull request does two things:

  • promotes the ReactionEmoji.Custom#asFormat method to ReactionEmoji to simplify converting a ReactionEmoji to a String displayable in the client
  • standardizes the creation of a displayable String for custom emoji across GuildEmoji and ReactionEmoji.Custom to reduce duplication

@kashike kashike changed the title Feature/reaction format Promote and standardize the creation of displayable strings for emoji Mar 2, 2023
@quanticc quanticc added this to the 3.3.0 milestone Mar 7, 2023
@quanticc quanticc added enhancement Improvement over an existing feature area/core Related to core module: events, entities, clients, specs labels Mar 19, 2023
@quanticc quanticc modified the milestones: 3.3.0, 3.3.0-M1 Mar 29, 2023
@quanticc quanticc merged commit 82bacbc into Discord4J:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NovaFox161 NovaFox161 NovaFox161 approved these changes

Assignees
No one assigned
Labels
area/core Related to core module: events, entities, clients, specs enhancement Improvement over an existing feature
Projects
None yet
Milestone
3.3.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kashike @NovaFox161 @quanticc