Migration to reactor.util.retry.Retry after old retry deprecation (#1125) #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface deprecation (Discord4J#1125)
Gregory-Widmer
commented
Apr 6, 2023
Comment on lines
+91
to
+98
| .doBeforeRetry(retrySignal -> { | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Retry {} in bucket {} due to {}", | ||
| retrySignal.totalRetries(), | ||
| id.toString(), | ||
| retrySignal.failure().toString()); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I had to remove the "for XXX seconds" indication here as the retrySignal doesn't provide any information about current ellapsed time. I did not find any workaround, as a first step I tried to compute the current duration but because we have a jitter it's random.
There was a problem hiding this comment.
I understand and it's fine. We could replicate it by creating a custom RetrySignal that contains the backoff value like in GatewayRetrySpec but it would be overkill for just a debug log line detail.
There's also a behavior change here to consider: 10 max attempts. Is that intentional? I agree with that too btw.
quanticc
added
the
API change
|
Noting the current API and behavior changes for 3.2.x branch in a separate commit/PR
|
quanticc
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: I tried to migrate from the old reactor Retry<?> interface to the abstract class reactor.util.retry.Retry and its two subclasses RetrySpec and RetryBackoffSpec.
I tried to refactor only, but it seems we have 2 functionnal changes that I'm going to describe in review below for feedback.
Justification: This PR fixes the issue #1125