Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onboarding support #1231

Merged
merged 10 commits into from
Jul 19, 2024
Merged

feat: add onboarding support #1231

merged 10 commits into from
Jul 19, 2024
+592 −1

Conversation

Azn9
Copy link
Member

@Azn9 Azn9 commented Jun 15, 2024 •
edited by Doc94
Loading

Requires Discord4J/discord-json#174

Closes #1188 and #1229

@Azn9 Azn9 added area/core Related to core module: events, entities, clients, specs PR depends on PR Another PR must be merged before this one labels Jun 15, 2024
@Azn9 Azn9 added this to the 3.3.0 milestone Jun 15, 2024
@Azn9 Azn9 requested a review from Doc94 June 15, 2024 21:05
@Azn9 Azn9 self-assigned this Jun 15, 2024
@Doc94 Doc94 removed the PR depends on PR Another PR must be merged before this one label Jul 16, 2024
@Doc94 Doc94 mentioned this pull request Jul 16, 2024
Merged
@Doc94
Copy link
Member

Doc94 commented Jul 16, 2024

Currently has a exception if the Onboarding has emojis with null name #1244

This was linked to issues Jul 17, 2024
Use emoji_id, emoji_name and emoji_animated fields instead of emoji in onboarding prompt creation or update #1188
Closed
Add support for onboarding #1229
Closed
@Doc94
Copy link
Member

Doc94 commented Jul 17, 2024

Looks like currently discord has a issue where the emoji returned its not consistent in the information.
discord/discord-api-docs#7006
i get a emoji with id marked "not animated" but in the guild endpoints where show the information about the emoji if is animated.

@Doc94
Merge branch '3.2.x' of github.com:Discord4J/Discord4J into fork/Azn9…
682ce5a 
…/feat/onboarding

# Conflicts:
#	core/src/main/java/discord4j/core/object/entity/Guild.java
@Doc94 Doc94 merged commit df675f2 into Discord4J:3.2.x Jul 19, 2024
6 checks passed
Doc94 added a commit that referenced this pull request Jul 19, 2024
@Doc94
Merge #1231 into 3.3.0
640e3a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doc94 Doc94 Doc94 approved these changes

Assignees

@Azn9 Azn9

Labels
area/core Related to core module: events, entities, clients, specs
Projects
3.3.0 Release
Status: Done
Milestone
3.3.0
2 participants
@Azn9 @Doc94