Fix some problematic uses of Possible::get #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darichey
added
the
area/core
quanticc
approved these changes
Jul 28, 2020
danthonywalker
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replace many uses of Possible::get with explicit
orElseThrow. These were mostly in places incoreentities where it wasn't clear previously if the fields actually had the potential to be absent. I have included comments to explain where the equivalentget()would have been safe.In the case of
Embed, many of the uses ofget()were not safe and resulted in errors. For now, they have been updated to returnnullinstead. A following PR targeted to 3.2 will make themOptional.Justification:
Fixes #747