Add support for server templates #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added routes to the Discord API
Created the Service for Template and edited a template route
RestTemplate entity and new method to templateservice and restclient
Added all the routes with comments.
Almost finished, need to optimise and provide access to the values.
Mostly sorted just came across an annoying error
Can now call all the values given in the template request and also fixed guild creation through template.
…iscord4J into Redstoneguy129-feature/templates
quanticc
added
area/core
darichey
reviewed
Mar 28, 2021
| @@ -0,0 +1,214 @@ | |||
| package discord4j.core.object; | |||
darichey
requested changes
Mar 28, 2021
There was a problem hiding this comment.
One thing on naming: Template or GuildTemplate? All of the specs use the latter. I think it would be good to rename the class to match.
There are also many unnecessary import and formatting changes that shouldn't be included in this PR.
Many of the classes are missing javadoc and license headers
| import java.util.Optional; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public class Template implements DiscordObject { |
| * | ||
| * @return the template code (unique ID) | ||
| */ | ||
| public final String getCode() { |
There was a problem hiding this comment.
I don't think these methods need to be final. Most of our entity classes are final, though.
| } | ||
|
|
||
| /** | ||
| * Requests to delete this template while optionally specifying a reason. |
There was a problem hiding this comment.
Is there a way to specify the reason? (does that even show up in Audit Log?)
| @@ -1368,6 +1383,18 @@ public OptionalInt getMaxMembers() { | |||
| .map(data -> new ExtendedInvite(gateway, data)); | |||
| } | |||
|
|
|||
| /** | |||
| * Requests to retrieve the invites of the guild. | |||
There was a problem hiding this comment.
Suggested change
| * Requests to retrieve the invites of the guild. | |
| * Requests to retrieve the templates of the guild. |
| /** | ||
| * Requests to retrieve the invites of the guild. | ||
| * | ||
| * @return A {@link Flux} that continually emits the {@link ExtendedInvite invites} of the guild. If an error is |
There was a problem hiding this comment.
Suggested change
| * @return A {@link Flux} that continually emits the {@link ExtendedInvite invites} of the guild. If an error is | |
| * @return A {@link Flux} that continually emits the {@link Template templates} of the guild. If an error is |
darichey
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off #831, applying requested changes: removing templates from StateHolder and rearranging some methods.
Close #791