Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable Discord base url #902

Merged
merged 1 commit into from Apr 21, 2021
Merged

Customizable Discord base url #902

merged 1 commit into from Apr 21, 2021

Conversation

schnapster
Copy link
Contributor

Description:

Allow providing a custom discord base url.

Justification:

More customizability for the library users.

@darichey
Copy link
Member

Is there any valid url except discord.com/api/{version}?

@schnapster
Copy link
Contributor Author

discordapp.com still works
There might be other uses like maybe running through some kind of proxy I guess.

@quanticc quanticc added area/rest Related to the rest module: request-stream, routes, rest-api enhancement Improvement over an existing feature labels Apr 20, 2021
@quanticc quanticc added this to the 3.2.0 milestone Apr 20, 2021
@quanticc quanticc merged commit 05e3ad2 into Discord4J:master Apr 21, 2021
@schnapster schnapster deleted the customize-discord-base-url branch May 2, 2021 17:40
@quanticc quanticc mentioned this pull request Sep 12, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanticc quanticc quanticc approved these changes

@darichey darichey darichey approved these changes

Assignees
No one assigned
Labels
area/rest Related to the rest module: request-stream, routes, rest-api enhancement Improvement over an existing feature
Projects
None yet
Milestone
3.2.0-M4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schnapster @darichey @quanticc