-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API v9 (Threads) #923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes
Base automatically changed from
change/channel-hierarchy-breaking
to
master
September 27, 2021 00:37
quanticc
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agree there's pending work but merging this will make this feature an early access (translation: expect many bugs) implementation, for general feedback at version 3.3.0-SNAPSHOT
I'm getting to the TODO exceptions in ThreadDispatchHandlers. |
skykatik
pushed a commit
to skykatik/Discord4J
that referenced
this pull request
Oct 3, 2021
* Initial work on threads * More work on threads * Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports * Use new channel hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
Related to core module: events, entities, clients, specs
feature-request
Request for a new library feature or behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for Discord API version 9 and channel threads.
Justification:
#916
Depends on Discord4J/discord-json#86