Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API v9 (Threads) #923

Merged
merged 24 commits into from
Sep 27, 2021
Merged

Support API v9 (Threads) #923

merged 24 commits into from
Sep 27, 2021

Conversation

darichey
Copy link
Member

Description:
Add support for Discord API version 9 and channel threads.

Justification:
#916

Depends on Discord4J/discord-json#86

@quanticc quanticc mentioned this pull request May 23, 2021
24 tasks
@quanticc quanticc added this to the 3.3.0 milestone Jul 3, 2021
@darichey darichey mentioned this pull request Jul 11, 2021
6 tasks
@darichey darichey changed the base branch from master to change/channel-hierarchy-breaking July 11, 2021 17:03
@darichey darichey changed the base branch from change/channel-hierarchy-breaking to master July 11, 2021 17:06
@darichey darichey added area/core Related to core module: events, entities, clients, specs enhancement Improvement over an existing feature labels Jul 11, 2021
@darichey darichey changed the base branch from master to change/channel-hierarchy-breaking July 11, 2021 17:23
@darichey darichey added feature-request Request for a new library feature or behavior and removed enhancement Improvement over an existing feature labels Aug 5, 2021
Base automatically changed from change/channel-hierarchy-breaking to master September 27, 2021 00:37
@quanticc quanticc marked this pull request as ready for review September 27, 2021 00:59
Copy link
Member

@quanticc quanticc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agree there's pending work but merging this will make this feature an early access (translation: expect many bugs) implementation, for general feedback at version 3.3.0-SNAPSHOT

@quanticc quanticc merged commit dfcc9fb into master Sep 27, 2021
@quanticc quanticc deleted the feature/threads branch September 27, 2021 01:06
@frankivo
Copy link

I'm getting to the TODO exceptions in ThreadDispatchHandlers.
So far, so good I suppose :)

skykatik pushed a commit to skykatik/Discord4J that referenced this pull request Oct 3, 2021
* Initial work on threads

* More work on threads

* Modify channel hierarchy in preparation for threads

* Use 'TopLevel' names instead of temp names, remove duplicate docs

* Add deprecation docs

* Add class docs

* Make CategorizableChannel extend TopLevelGuildChannel

* Make breaking channel hierarchy changes

* (Re)move methods deprecated in preparation for threads
* Move most base channel method implementations to default methods
* Remove most base channel classes

* Don't deprecate GuildChannel#getEffectivePermissions

* Remove BaseTopLevelGuildChannel, add license headers, docs

* Remove unused imports

* Remove unused imports

* Use new channel hierarchy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Related to core module: events, entities, clients, specs feature-request Request for a new library feature or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants