-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implant web proxy support #1556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR and sorry about the late response, there are some problems listed below that need to be addressed before this can be merged
Thanks for the reply, it has been a while before the PR has been created, please wait for me to resolve the conflicts and fix the issues. |
7c6911d
to
c27089e
Compare
@Vankka Hi. Please check the new codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably missed something since the comments are squished together.
You still need to include the config options in all the other config files. Don't worry about translating them, you can just copy the english translation across them all.
@granny Issue resolved, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more things. The english translation of the comment can be changed if you think of a better way to word it.
It would probably be a good idea to add debug lines stating something along the lines of "using proxy for Discord".
@granny work done, also I attempted to fix the failed build due to error |
Synced develope branch changes to patch-1 |
Anyone still aware of the PR? |
Thank you for your PR! |
Migrate from #1554
(Sorry for multiple PRs, I had to resolve the conflicts)