New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: throw error if dont have cityCode #520

Merged

Swind merged 1 commit into master from get-cityCode

Mar 29, 2021

Contributor

LittleWhiteYA commented Mar 24, 2021 •

edited

Summary

close #507

在這邊就先拿出 cityCode，避免後面要用到的時候噴出的 error 會是取不到值，會比較難 debug


          refactor: throw error if dont have cityCode

04b6b3b

LittleWhiteYA requested a review from Swind

March 24, 2021 13:26

Contributor

Swind commented Mar 29, 2021

LGTM

Swind merged commit c73d7ba into master

LittleWhiteYA deleted the get-cityCode branch

June 14, 2021 15:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment