Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement role subscription fields #904

Merged
merged 13 commits into from Feb 22, 2023
Merged

feat: implement role subscription fields #904

merged 13 commits into from Feb 22, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jan 4, 2023 •
edited

Summary

discord/discord-api-docs#5724

The new integration type is untested due to region locks (:/), though I don't see why it wouldn't work as the integration structure wasn't changed.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jan 4, 2023
@shiftinv shiftinv added this to the disnake v2.8 milestone Jan 4, 2023
@shiftinv shiftinv mentioned this pull request Jan 10, 2023
Merged
8 tasks
Victorsitou
Victorsitou reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@Victorsitou Victorsitou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, and it works fine, left some docs reviews c:

disnake/emoji.py Outdated Show resolved Hide resolved
disnake/guild.py Outdated Show resolved Hide resolved
shiftinv and others added 3 commits January 11, 2023 20:06
@shiftinv @Victorsitou
docs: emoji/emojis
fe09ebb 
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com>
Signed-off-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@shiftinv
docs: add more premium emoji details
07bf0b7
@shiftinv
Merge remote-tracking branch 'upstream/master' into feature/role-subs…
89eda46 
…criptions
@shiftinv shiftinv modified the milestones: disnake v2.8, disnake v2.9 Feb 5, 2023
onerandomusername
onerandomusername reviewed Feb 19, 2023
View reviewed changes
docs/api.rst Outdated Show resolved Hide resolved
onerandomusername
onerandomusername requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested as much as was possible, looks good other than these two comments

disnake/role.py Show resolved Hide resolved
disnake/integrations.py Show resolved Hide resolved
@onerandomusername onerandomusername enabled auto-merge (squash) February 22, 2023 04:21
@onerandomusername onerandomusername enabled auto-merge (squash) February 22, 2023 04:21
@onerandomusername onerandomusername merged commit cc6986c into DisnakeDev:master Feb 22, 2023
@onerandomusername onerandomusername deleted the feature/role-subscriptions branch February 22, 2023 04:22
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorsitou Victorsitou Victorsitou left review comments

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shiftinv @Victorsitou @onerandomusername